Fix imaginary friend ears and icons #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tside the world if set to only hear nearby)
fira
added
the
Testmerge Candidate
…end_Ears_And_Icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR changes the imaginary friend ability to an orbit ability. The reasoning for this is because if you have ghost ears set to only hear nearby, merging would place you in the mob's contents so not in range to hear anything.
This PR also fixes the hide ability not actually updating its icon state.
Explain why it's good for the game
Imaginary friends need to be able to hear who they are helping.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/95TtYocF2XQ
Changelog
🆑 Drathek
fix: Fixed imaginary friend merge ability preventing hearing if ghost ears are set to only nearby.
fix: Fixed imaginary friend hide ability not updating its icons.
/:cl: