Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M4 Synthetic PMC 'armor' changes p1 #4867

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Nov 7, 2023

About the pull request

this is #4758 but atomized, this one only changes code, next one will only change sprite. the conflicts involved with sprites was quite ridiculous

Basically M4 PMC Synthetic 'armor' stated it offered 'maximum protection' even though it offers quite literally 0. Furthermore this complete lack of protection does not constitute the 20% slowdown netted.

So I'm fixing the description to state clearly that there is NO ARMOR OFFERED and furthermore, lowering it to a 10% slowdown(Justified by having 1 extra storage space?). I think this is a step in teh right direction for now.

10% comes from a new category called SUPERLIGHT which will be used for this only atm. May go to other stuff later.

Explain why it's good for the game

Description should match what an item offers and not be misleading. If it says it has armor - it should have armor. If it isn't gonna have armor, it shouldn't say so.

Next, 20% slowdown is A HUGE price for 1 single storage slot. Its almost ridiculous. Hopefully 10% is better :)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: SUPERLIGHT armor category.
balance: M4 Synthetic Armor slows by 10% to justify having 1 extra storage slot.
spellcheck: Clarifies M4 Synthetic Armor description that it does not have any armor whatsoever.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Nov 7, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as last time, it's fine on here but not the regular util vest, etc.

@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Nov 7, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Nov 10, 2023
Merged via the queue into cmss13-devs:master with commit 2e8f3a3 Nov 10, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants