Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fax template images for CDN #4872

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Nov 7, 2023

About the pull request

This PR fixes the fax templates' images for the paper background and WY logo. They were not using the URL mapping when using a CDN.

Explain why it's good for the game

Immersion. A broken image with the caption "Something fucked!" is goofy.

Testing Photographs and Procedure

Screenshots & Videos Broken:

image

Working:

image

Changelog

🆑 Drathek
fix: Fixed fax template images in CDN mode
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 7, 2023
@harryob harryob added this pull request to the merge queue Nov 9, 2023
Merged via the queue into cmss13-devs:master with commit 79b9265 Nov 9, 2023
28 checks passed
@Drulikar Drulikar deleted the Fix_Fax_Template_Images branch November 9, 2023 04:42
cm13-github added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants