QoL addition and adjustment to squad role vendors. #4876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 8, 2023 11:09
vendor in helmet optic section at the cost of 30 point exept SL at 20 like it was.
to match the price of all the other squad member and moved roller bed to utility for SL as well as moving medical optic to optic section
to all the squad member that didn't have it. added acces to E-tool sandbag barbed wire small welderand fuel canister to everyone
for all three type of binocular price are 5 10 15... exept SL price are 3 5 8
moved C4 and breaching charge to Enginier supplies section
other squad role more
github-actions
bot
added
Quality of Life
added 3 commits
November 8, 2023 13:33
added data detector in SL and TL vendor
primary and sidearm SG and spe only have sidearm
armor made also that restricted firearm are always before ammo. and explosives
|
i will update changelog and all when if fixed it. if you know what's wrong tell me... |
Birdtalon
reviewed
Nov 8, 2023
code/game/machinery/vending/vendor_types/intelligence_officer.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_engineer.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_leader.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_medic.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_rifleman.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_smartgunner.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_specialist.dm
Outdated
Show resolved
Hide resolved
code/game/machinery/vending/vendor_types/squad_prep/squad_tl.dm
Outdated
Show resolved
Hide resolved
Drulikar
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Please stick to maintaining the same access to items in a pr like this, especially with how ambiguous the changelog is. Remove all changes (additional access to NVG) that result in this requiring balance considerations. Keep this as a quality of life update. If you want additional access to NVG to be considered, have that be a PR all by itself.
added 2 commits
November 8, 2023 18:55
remove night vision from everyone that didn't had it
realforest2001
requested changes
Nov 14, 2023
Huffie56
removed
the
Balance
|
going to do a PR way smaller and atomized... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Change how section order to make it more standardize and hopefully more new user friendly.
add a new section binoculars and generalize the usage to engineering supply, primary ammunition and sidearm ammunition
Main balance change is the cost of sandbag from 20 to 15 and making it accessible to every squad role also added a stack of 5 barbed wire for 5 point
Explain why it's good for the game
This PR is mainly to improve QoL and go to standardize how squad role propose to each role as much as possible.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
qol: Change order of section in squad roles vendors to put clothing and armor first then medical and engineering.
qol: add the IO to the new squad role vendor standard.
qol: separate ammunition section into primary and sidearm ammunition.
add: added an engineering section to all squad vendor role with sandbag barbed wire, E-tool, Fuel Canister and ME3 hand welder.
code: made binoculars be their own section for all squad vendor role.
/:cl: