-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starts refactoring Xenomorph.dm and other xenocode. #4941
Conversation
…arate files for caste_datum and hive_status
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This is going to be a nightmare to review I should have saved the file structure changes to a different PR but didn't think at the time. Frustration at xeno_defines.dm not being for xeno defines got to me 😢 |
I am going to split this into atomic PR |
About the pull request
This PR attempts to begin refactoring parts of Xenocode. It's all over the place and I had to start somewhere. Starting to forget what I've done so far and this is getting quite big. So this is mainly to keep track of things as my memory is that of a goldfish 🐟
File Structure:
/datum/caste_datum
and associated code out of xeno_defines.dm into caste_datum.dm (new)/datum/hive_status
now lives in hive_status.dm (new)/datum/hive_status_ui
moved form hive_status.dm lives in hive_status_ui.dm/datum/xeno_mark_define
moved to xeno_marks.dm (new)Code:
set_hive_and_update()
, movesistype(src)
to the subclasses for larva and queenGLOB.all_xenos
every time.istype(src)
in/mob/living/carbon/xenomorph/larva/update_icons()
we already havestate_overide
here for this reason.update_icons()
and into its owngenerate_name()
generate_name()
Removedhandle_name()
and moved everything togenerate_name()
generate_name()
to change from "Bloody larva" to "mature" is now in...larva/Life()
instead of inupdate_icons()
sinceupdate_icons()
was called on every Life() tick anyway./mob/living/carbon/xenomorph/Initialize()
removes a few duplicate proc calls,generate_name()
called twice,recalculate_actions()
called twice etc.Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
code: Starts refactoring, standardising and cleaning Xenomorph.dm and hive_status.
add: Little easter egg for 666 xeno number.
/:cl: