Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors Xenomorph initialize #4991

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Refactors Xenomorph initialize #4991

merged 5 commits into from
Nov 29, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Nov 21, 2023

About the pull request

Refactors /mob/living/carbon/xenomorph/Initialize() removes a few duplicate proc calls, generate_name() called twice, recalculate_actions() called twice etc.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Refactiors xenomorph initialize & removes some duplicate proc calls
/:cl:

@Birdtalon Birdtalon changed the title Refactors Xenomorph Intiialise Refactors Xenomorph initialize Nov 21, 2023
@github-actions github-actions bot added the Code Improvement Make the code longer label Nov 21, 2023
@fira fira added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Nov 22, 2023
@Birdtalon
Copy link
Contributor Author

Some bugs to fix.

@Birdtalon Birdtalon marked this pull request as draft November 24, 2023 18:21
@Birdtalon
Copy link
Contributor Author

Birdtalon commented Nov 24, 2023

Fixed bug. Accidently passed hivenumber instead of src.hivenumber to SStracking so we were effectively tracking null on evolve.

Also fixes the runtime when leaders evolve with leader star, HUDs now get set up before we transfer that.

@Birdtalon Birdtalon marked this pull request as ready for review November 24, 2023 18:56
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 25, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 25, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@harryob harryob marked this pull request as draft November 27, 2023 10:47
@Birdtalon Birdtalon marked this pull request as ready for review November 27, 2023 22:27
@fira fira added this pull request to the merge queue Nov 29, 2023
Merged via the queue into cmss13-devs:master with commit c86715c Nov 29, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Nov 29, 2023
@Birdtalon Birdtalon deleted the xenoinit branch December 21, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants