Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix human explosion runtime #4966

Closed
wants to merge 1 commit into from

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Nov 19, 2023

About the pull request

image

@Zonespace27 Zonespace27 added the Fix Fix one bug, make ten more label Nov 19, 2023
@fira
Copy link
Member

fira commented Nov 19, 2023

I don't think this is the correct way to fix this. There are several other places that also rely on pick(limbs) in chemical code that would have the same issue, and limbs should never be null, the limbs include chest

Presumably the only way this would end up with nulled/empty limbs is if the humans was deleted to begin with

@Zonespace27
Copy link
Contributor Author

I don't think this is the correct way to fix this. There are several other places that also rely on pick(limbs) in chemical code that would have the same issue, and limbs should never be null, the limbs include chest

Presumably the only way this would end up with nulled/empty limbs is if the humans was deleted to begin with

Gah, forgot that the chest was a limb. Will look into further, this isn't the right fix.

@Zonespace27 Zonespace27 marked this pull request as draft November 20, 2023 00:05
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 27, 2023
@github-actions github-actions bot closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants