Refactors Xeno name generation and set hive and update #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
fira
approved these changes
Nov 23, 2023
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
cm13-github
added a commit
that referenced
this pull request
Dec 1, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2023
# About the pull request #4992 broke non normal hive nick numbering due to an oversight. You will laugh when you see why. This fixes that. # Explain why it's good for the game # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog 🆑 fix: Fixed non normal xeno hive nick numbering /🆑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Refactors xenomorph name generation. Everything is now handled in
generate_name(). Refactored outistype(src)Larva name generation no longer handled in
update_icons()All hive datums now have a list of 1-999 which gets picked from. If that list is empty it will fall-back on 0. I can add functionality for generating a new list but seriously when do we ever get through 999 lives.
Removes
istype(src)fromset_hive_and_update()Adds "Infernal" name prefix for xeno who rolls 666 as a little easter egg.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: "Infernal" name prefix for xeno who rolls number 666
code: Refactors xeno name generation. Larva name generation and removes some istype(src)
/:cl: