Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropship sidedoors #4995

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Dropship sidedoors #4995

merged 4 commits into from
Nov 24, 2023

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Nov 22, 2023

About the pull request

Replaces the pairs of 1-wide sidedoors on dropships with a 2-wide sidedoor. Icons are identical to the 1-wide sidedoors with the door part widened.

Explain why it's good for the game

Two less moving parts that might accidentally get opened just as a lockdown or launch is initiated thus locking it open at the worst possible time. Also, I think it looks cleaner.

Testing Photographs and Procedure

Screenshots & Videos

Before
image
image

After
image
image

Changelog

🆑
imageadd: 2-wide dropship side doors
maptweak: changed dropship side doors to a lone doublewide door
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? labels Nov 22, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Nov 22, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Might want to also edit the crashed ship on CC for consistency

@Doubleumc
Copy link
Contributor Author

Swapped the doors on the CC crashed ship (Typhoon) as well, good catch. Adjusted their dirs to align the hitbox with the sprite; multitile doors are weird.

@harryob harryob added this pull request to the merge queue Nov 24, 2023
Merged via the queue into cmss13-devs:master with commit 0d05880 Nov 24, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 24, 2023
@Doubleumc Doubleumc deleted the dropship-sidedoors branch November 25, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants