Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORSAT poddoor and LZ fixes #5029

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Nov 25, 2023

About the pull request

Fixes CORSAT's LZs so that they can be landed on using the modern shuttle system.

Removed the icon from poddoors supposedly invisible filler_object so they will actually be invisible, as intended. There's a lot more to be said about wide poddoors using a completely separate system from wide airlocks but -- well, I don't want to.

Explain why it's good for the game

A little less friction using an unmaintained map like CORSAT.

Testing Photographs and Procedure

Screenshots & Videos

Before, LZs
image
Before, closed poddoors
image
Before, open poddoors
image

After, LZs
image
After, closed poddoors
image
After, open poddoors
image

Changelog

🆑
fix: CORSAT poddoors no longer have extra sprites overlaid on them
maptweak: CORSAT LZs can be used by shuttles
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Fix Fix one bug, make ten more labels Nov 25, 2023
@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Nov 26, 2023
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping seems fine, but corsat needs a lot more work if ya aught to bring it back so be warned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't intend to bring it back. Just want it to be functional without admins having to mess with stuff, for special events and such.

@harryob harryob added this pull request to the merge queue Nov 26, 2023
Merged via the queue into cmss13-devs:master with commit b7ab02b Nov 26, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Nov 26, 2023
@Doubleumc Doubleumc deleted the CORSAT-poddoors-lzs branch November 26, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants