Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional M5 Gasmask #5072

Closed
wants to merge 3 commits into from
Closed

Conversation

Ediblebomb
Copy link
Contributor

About the pull request

Makes the M5 Gasmask actually work
70% NVG code 30% trial and error

Explain why it's good for the game

Consistency, the regular gasmask protects you against CN20 Nerve Gas, whereas the helmet gasmask previously did not.

Testing Photographs and Procedure

Screenshots & Videos
Gas.mp4

Changelog

🆑 Ediblebomb
add: M5 Helmet Gasmask now functions as a gasmask when in a marine helmet (and yes, gasmasks do still have some functionality)
/:cl:

70% NVG code 30% trial and error
@github-actions github-actions bot added the Feature Feature coder badge label Nov 29, 2023
code/game/objects/items/props/helmetgarb.dm Outdated Show resolved Hide resolved
code/game/objects/items/props/helmetgarb.dm Outdated Show resolved Hide resolved
code/game/objects/items/props/helmetgarb.dm Outdated Show resolved Hide resolved
code/game/objects/items/props/helmetgarb.dm Outdated Show resolved Hide resolved
@Ediblebomb
Copy link
Contributor Author

Oh so that's what that button does, oops.

@Ediblebomb
Copy link
Contributor Author

I'll reopen this when I fix that

@Ediblebomb Ediblebomb closed this Nov 30, 2023
@Ediblebomb Ediblebomb deleted the Gasmask branch November 30, 2023 21:19
@Ediblebomb
Copy link
Contributor Author

#5083

github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2023
# About the pull request
Makes the M5 Gasmask actually work
70% NVG code 30% trial and error

### This time I *probably* won't fuck things up.
#5072 
# Explain why it's good for the game
Consistency, the regular gasmask protects you against CN20 Nerve Gas,
whereas the helmet gasmask previously did not.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


https://github.com/cmss13-devs/cmss13/assets/95509996/8f4c2eed-4ad6-477d-83d4-1b87630d7ff7

</details>

# Changelog
:cl: Ediblebomb
add: M5 Helmet Gasmask now functions as a gasmask when in a marine
helmet (and yes, gasmasks do still have some functionality)
/:cl:

---------

Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants