Functional M5 Gasmask 2: Electric Boogaloo #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70% NVG code 30% trial and error
Closed
fira
requested changes
Dec 3, 2023
There was a problem hiding this comment.
Uh... You can't just edit flags like this, helmets have subtypes with different flags that would get removed when you remove the gas mask. This is ideally a job for traits but that needs refactoring said flags
At the very least you need to use initial() here - and i'm not sure it's enough depending on item interactions
I don't want to make Functional M5 Gasmask 3: Fucking With Functional Code To Make One Obscure Feature Work Better
Drulikar
requested changes
Dec 5, 2023
Drulikar
requested changes
Dec 5, 2023
Drulikar
requested changes
Dec 6, 2023
Co-authored-by: Drathek <[email protected]>
Drulikar
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Makes the M5 Gasmask actually work
70% NVG code 30% trial and error
This time I probably won't fuck things up.
#5072
Explain why it's good for the game
Consistency, the regular gasmask protects you against CN20 Nerve Gas, whereas the helmet gasmask previously did not.
Testing Photographs and Procedure
Screenshots & Videos
Gas.mp4
Changelog
🆑 Ediblebomb
add: M5 Helmet Gasmask now functions as a gasmask when in a marine helmet (and yes, gasmasks do still have some functionality)
/:cl: