fix(preferences): fixes saving of certain preferences #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
previously approved these changes
Dec 3, 2023
fira
reviewed
Dec 3, 2023
Drulikar
dismissed
their stale review
Changes made post approval that require testing
Drulikar
approved these changes
Dec 4, 2023
cm13-github
added a commit
that referenced
this pull request
Dec 4, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
# About the pull request This PR is a followup to #5110 and #2926 making it so we only save the `key_bindings` value rather than all preferences. I'd be inclined to just not save at all, but the initial commit on the ported input system has us saving `remembered_key_bindings` just a few lines down anyways so no matter what we're writing something. # Explain why it's good for the game Should better future proof this trampling preferences, but still retain existing behavior where any automatically rebound keys are immediately saved. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: Drathek code: Reduced most preference re-saving when preferences are initially loaded /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixed the saving of certain prefs, like DISABLING RADIAL MENUS (important!!!) among others.
I'm too lazy to list them out so heres a screenshot with list of prefs that are fixed.
Changelog
🆑
fix: fixed saving of certain preferences.
/:cl: