Adds a scaling direct hit sound to the XM88 #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Sound
fira
reviewed
Dec 4, 2023
phone edit
harryob
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds a scaling impact sound for every direct hit you obtain with the XM88, depending on the current penetration value.
Explain why it's good for the game
The bullseye mechanic makes this weapon very, very powerful. However, you don't really feel like you're doing any more damage with it. The XM88 doesn't really give the user any proper feedback if they're managing to nail several direct hits. A good sound effect can give them a dopamine rush, and in turn, make the weapon more fun to use.
Testing Photographs and Procedure
Screenshots & Videos
xm88.mp4
Changelog
🆑
soundadd: The XM88 now has a scaling hit sound for every direct hit you manage to land with it.
/:cl: