Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes almost all silicon code #5126

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Removes almost all silicon code #5126

merged 8 commits into from
Jan 18, 2024

Conversation

fira
Copy link
Member

@fira fira commented Dec 4, 2023 •
edited
Loading

About the pull request

Removes every non-synth non-organic mob code and any related items and backend.

Okay i lied, we get to keep ARES..... ARES' cool.

Explain why it's good for the game

Less code bloat. It was about time we did this...

Testing Photographs and Procedure

Game isn't on fire when starting it. Does that mean everything works? We'll know in TM.

Changelog

🆑
del: Removed AIs.
del: Removed Cyborgs.
del: Removed Maintenance Drones.
del: Removed Camera chunking for AIs, and all associated dynamic updates.
del: Removed Robotic equipment items.
del: Removed Robotic and AI transformation tools.
del: Removed Robotic Transformation Disease.
del: Removed Nanites. Roburgers are now all safe to eat.
del: Removed functionality from AI machinery and AI card. They're props now.
/:cl:

@github-actions github-actions bot added the Removal snap label Dec 4, 2023
@fira fira changed the title Removes non-organics Makes all non-organics synths Dec 4, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 6, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@fira fira changed the title Makes all non-organics synths Removes almost all silicon code Dec 8, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 8, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 14, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 19, 2023
@Birdtalon Birdtalon added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Dec 26, 2023
@Birdtalon
Copy link
Contributor

Ideally we should TM this and see if anything unintended breaks.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 29, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 2, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 10, 2024
@Birdtalon Birdtalon removed the Stale beg a maintainer to review your PR label Jan 10, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 13, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

harryob
harryob approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ss13 codebase free of borg code what a miracle

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 18, 2024
@harryob harryob added this pull request to the merge queue Jan 18, 2024
Merged via the queue into cmss13-devs:master with commit e302c54 Jan 18, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 18, 2024
@cm13-github
Automatic changelog for PR #5126 [ci skip]
d76b4fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Removal snap Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fira @cm13-github @Birdtalon @harryob