-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Armor Light Buff for Heavy/Medium/Leader armor #5130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Medium armors and buffs to heavy and medium for range+power
github-actions
bot
added
Mapping
did you remember to save in tgm format?
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Code Improvement
Make the code longer
labels
Dec 5, 2023
Would like this tested when there's spot from the many TM's in currently, and ofc, these numbers are something I'm willing to adjust from tests and feedback. |
Removed repeat variables
Nanu308
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Dec 7, 2023
Fixes random armor sprites occurring when vending
3 tasks
3 tasks
3 tasks
Pretty certain your medium repathing made heavy / b12 / medium the same speed |
3 tasks
3 tasks
Zonespace27
added
the
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
label
Dec 13, 2023
cm13-github
added a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Code Improvement
Make the code longer
Mapping Approved
adds 500 new dict keys
Mapping
did you remember to save in tgm format?
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This increases the armor light range and power of the Medium and Heavy armor as well as the Leader aka the B12 SL armor.
Explain why it's good for the game
Currently, Light armor is still the most popular armor from what I've seen so I'm hoping this will help a bit to bring heavy/medium armor more in line with the popularity of light armor.
I also believe this could help combat the claustrophobia some people feel with how encroaching the darkness can be, but i do not wish to give too much light to marines as i believe how scary the darkness feels now is overall good for the game and i wish to attempt this as a middle ground.
Testing Photographs and Procedure
Medium Armor:
Leader Armor:
Changelog
🆑
balance: Adjusted how much light is given by standard marine armor.
balance: Light Armor remains the same range & power, Medium armor now gives a bit more light, Leader B12 armor gives a bit more light & range, M4 (rto) gives a bit more light, and Heavy armor give the most light and range compared to before.
code: Changed inheritance for medium armor as the different sprite versions were laid directly under the parent type instead of the medium one and so forth.
/:cl: