-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor shutter and linked buttons in CL office. #5149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
did you remember to save in tgm format?
Quality of Life
Make the game harder to play
Refactor
Make the code harder to read
labels
Dec 6, 2023
Nanu308
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Drulikar
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaked the changelog - everything looks fine though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mapping Approved
adds 500 new dict keys
Mapping
did you remember to save in tgm format?
Quality of Life
Make the game harder to play
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
basically refactoring shutter and buttons also adding lights because it was too dark for an office and some button and separation for qol while i was there...
Explain why it's good for the game
1-i added the three door because it's dark
2-i separated the shutter for the windows and the door because it seem like it's been something simple that make sense
3-added the button to the shutter for the door inside because it's way more practical.
4-refactoring code to be less dmm dependent because it's cleaner and avoid to touch dmm file if you want to modify them in the future...
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
maptweak: added a button inside the CL office to open the shutter for the door and rearranged other buttons.
maptweak: separated shutter for cl office door and for the windows.
maptweak: add three lights in CL office and quarter.
/:cl: