Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor shutter and linked buttons in CL office. #5149

Merged
merged 16 commits into from
Dec 7, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Dec 6, 2023

About the pull request

basically refactoring shutter and buttons also adding lights because it was too dark for an office and some button and separation for qol while i was there...

Explain why it's good for the game

1-i added the three door because it's dark
2-i separated the shutter for the windows and the door because it seem like it's been something simple that make sense
3-added the button to the shutter for the door inside because it's way more practical.
4-refactoring code to be less dmm dependent because it's cleaner and avoid to touch dmm file if you want to modify them in the future...

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
maptweak: added a button inside the CL office to open the shutter for the door and rearranged other buttons.
maptweak: separated shutter for cl office door and for the windows.
maptweak: add three lights in CL office and quarter.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Quality of Life Make the game harder to play Refactor Make the code harder to read labels Dec 6, 2023
@Huffie56 Huffie56 marked this pull request as ready for review December 6, 2023 21:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Dec 7, 2023
@Drulikar Drulikar removed the Refactor Make the code harder to read label Dec 7, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the changelog - everything looks fine though.

@harryob harryob added this pull request to the merge queue Dec 7, 2023
Merged via the queue into cmss13-devs:master with commit b847e96 Dec 7, 2023
29 checks passed
cm13-github added a commit that referenced this pull request Dec 7, 2023
@Huffie56 Huffie56 deleted the cl_office_shutters branch December 9, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants