Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes base Warrior's sprite with unused Knight strain's sprite. #5214

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Changes base Warrior's sprite with unused Knight strain's sprite. #5214

merged 1 commit into from
Dec 18, 2023

Conversation

NessiePendragon
Copy link
Contributor

@NessiePendragon NessiePendragon commented Dec 13, 2023 •
edited by github-actions bot
Loading

About the pull request

I'm making this pr on behalf of InsaneRed, who has permission from the sprite's owner.
resim_2023-12-13_180715849

Explain why it's good for the game

Changes up the Warrior sprite with something that looks closer to the Prae evolution and closer to Defender.

Testing Photographs and Procedure

Screenshots & Videos

Screenshot_69
Screenshot_70
warrior1
warrior2
warrior3
warrior4

Changelog

🆑
add: Added new sprites for Warrior.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Dec 13, 2023
@NessiePendragon NessiePendragon changed the title Changes base Warrior sprite with unused Knight strain's sprite. Changes base Warrior's sprite with unused Knight strain's sprite. Dec 13, 2023
@kooarbiter
Copy link

the pipes on the back north facing sprite are a little incongruous with the rest of the xeno sprites, i know they're a signature part of the alien's design but afaik we don't show them like that on any other xeno.

@Red-byte3D
Copy link
Contributor

We do on praetorian and lurker sprites

nauticall
nauticall approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeppers

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Dec 18, 2023
@Birdtalon Birdtalon added this pull request to the merge queue Dec 18, 2023
Merged via the queue into cmss13-devs:master with commit 0fd5d8c Dec 18, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Dec 18, 2023
@cm13-github
Automatic changelog for PR #5214 [ci skip]
a114540
@Drulikar Drulikar mentioned this pull request Dec 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2023
@Drulikar
Update weeded warrior sprites (#5250)
4a29849 
# About the pull request

This PR is a followup to #5214 to fix the weeded warrior sprites that
didn't get updated.

# Explain why it's good for the game

Fixes this:

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/78a98ca3-7d6d-4a5d-a57a-e67e69e6ee58)


# Testing Photographs and Procedure

![warrior](https://github.com/cmss13-devs/cmss13/assets/76988376/f7b7f547-66c0-447a-b290-c37b96f67f2b)

# Changelog
:cl: Drathek
imageadd: Update weeded warrior sprites to be compatible with knight
strain sprite
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nauticall nauticall nauticall approved these changes

Assignees
No one assigned
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NessiePendragon @kooarbiter @Red-byte3D @nauticall @Birdtalon