Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive UI pylon crash fix #5249

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Dec 18, 2023

About the pull request

This is a ref not a new list so we remove huggers/lessers etc from the hive and crash the UI every time the pylon calls give_larva() Big credit to Fira for doing most of the work on finding this.

Discord_2023-12-18_21-31-58

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Birdtalon, Fira
fix: Fixes hive UI crash upon pylon giving new larva.
/:cl:

@Birdtalon Birdtalon changed the title new list Hive UI pylon crash fix Dec 18, 2023
@github-actions github-actions bot added the Feature Feature coder badge label Dec 18, 2023
@Birdtalon Birdtalon added Fix Fix one bug, make ten more Testmerge Candidate we'll test this while you're asleep and the server has 10 players and removed Feature Feature coder badge labels Dec 18, 2023
@Birdtalon Birdtalon marked this pull request as draft December 18, 2023 21:52
@Birdtalon Birdtalon marked this pull request as ready for review December 18, 2023 21:54
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly

@Drulikar Drulikar added this pull request to the merge queue Dec 19, 2023
Merged via the queue into cmss13-devs:master with commit f733a56 Dec 19, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Dec 19, 2023
@Birdtalon Birdtalon deleted the hivestatusuiclueless branch December 21, 2023 13:42
@Birdtalon Birdtalon restored the hivestatusuiclueless branch December 21, 2023 13:42
@SabreML SabreML mentioned this pull request Dec 27, 2023
3 tasks
@Birdtalon Birdtalon deleted the hivestatusuiclueless branch February 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants