camera console now uses camera manager #5310
Conversation
Co-authored-by: Drathek <[email protected]>
Co-authored-by: Drathek <[email protected]>
Co-authored-by: Drathek <[email protected]>
| @@ -191,7 +200,7 @@ | |||
| // Cameras that get here are moving, and are likely attached to some moving atom such as cyborgs. | |||
| last_camera_turf = get_turf(cam_location) | |||
|
|
|||
| var/list/visible_things = current.isXRay() ? range(current.view_range, cam_location) : view(current.view_range, cam_location) | |||
| var/list/visible_things = current.isXRay() ? range("[target_width]x[target_height]", cam_location) : view("[target_width]x[target_height]", cam_location) | |||
There was a problem hiding this comment.
This change seems to just produce incorrect results in every view:
Despite it having a 7 and 7 for width and height, it made a view of 5x7.
If its not merely because you don't have the fix setting target_width and target_height in /datum/component/camera_manager/proc/set_camera_rect(source, x, y, z, w, h) like in #5298 then I'm not sure.
There was a problem hiding this comment.
I also recommend using 515.1609+ so you don't have the viewport sizing bug.
There was a problem hiding this comment.
Reverting only that line the views seem to be properly displayed:
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
I'll resolve conflicts today |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
# Conflicts: # code/game/machinery/computer/camera_console.dm
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
About the pull request
Continuing the work of #5309 - camera code now uses camera manager component.
Explain why it's good for the game
Reduction of duplicated code.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: camera consoles now use camera manager component
/:cl: