Polish Dropship Weapons UI

[Drulikar]

About the pull request

This PR is a follow up to #4812 polishing minor issues that were discovered but not addressed in that PR.

• Fire missions can now be scrolled in target acquisition
• The target selection in equipment view is now the same as other panels (and can be scrolled now too)
• Fixed deploying equipment like the spotlight and sentry
• Partially fixed camera view for sentry (map size doesn't always get set correctly some reason)
• Fixed the extra scrolling of fire missions
• Fixed the scrolling of target selection being a fixed quantity of 10 targets
• Improved menuing for the fire mission and strike sub menus
• Fixed strike ready messaging
• Map and Cam buttons are now mutually exclusive to one another (would just break the byond UI)
• Camera now resets when a CAS flare is destroyed (unless fire mission is underway)
• Camera now resets when sentry undeploys (if it was being used)
• Tweaked some button placements
• Fixed medevac layout
• Fixed direct fire (strike & equipment)
• Fixed camera views not handling /datum/component/overlay_lighting correctly (fixed by using TILE_BOUND planes; but will note it won't work completely correct if on a byond version prior to 515.1609 because of https://www.byond.com/forum/post/2873835)
• Fixed some hard deletes in /client/proc/clear_map based on Harddeletes: Accident edition tgstation/tgstation#61562
• Renamed nvgon and nvgoff to NV-ON and NV-OFF

Explain why it's good for the game

Fixes issues such as (but not limited to):

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑 Drathek
ui: Polished various aspects of the new dropship weapons UI
fix: Fixed CAS direct firing
fix: Fixed Medevac buttons not moving the dropship (still currently requires manual winch)
fix: Fixed camera_manager resizing the view incorrectly because of overlay_lighting
refactor: Ported some hard delete fixes for maps.
/:cl:

[fira]

LGTM - is that TM worth?

[eMiiXi]

I was told to comment on the actual PR to report bugs/issues.
With this current PR its impossible to do direct fire on target, so it makes Napalm missile, and dropping turrets impossible.
I have extensively tried to go into Equip > Select the weapon i want to direct fire and the target > Press FIRE. Nothing happens.
I also went into target mode > Strike > Weapon > Select a missile that its currently loaded and i want to fire on target > Press FIRE. Nothing happens. Other PO's have also reported the same issue and being unable to use direct fire at all, and unable to drop turrets or napalm because of this. The only way to currently do direct fire is to do a entire fire mission for it, but some things like Napalm can only be fired by direct, and are restricted from being added into a fire mission.

Also, when using medevac, you can click Equip to go back to the main selection of installed modules/guns, but when you do fulton the equip button is not there, just minor QoL, but makes it so you have to full back then go into equip again.

[Drulikar]

I was told to comment on the actual PR to report bugs/issues. With this current PR its impossible to do direct fire on target, so it makes Napalm missile, and dropping turrets impossible. I have extensively tried to go into Equip > Select the weapon i want to direct fire and the target > Press FIRE. Nothing happens. I also went into target mode > Strike > Weapon > Select a missile that its currently loaded and i want to fire on target > Press FIRE. Nothing happens. Other PO's have also reported the same issue and being unable to use direct fire at all, and unable to drop turrets or napalm because of this. The only way to currently do direct fire is to do a entire fire mission for it, but some things like Napalm can only be fired by direct, and are restricted from being added into a fire mission.

Also, when using medevac, you can click Equip to go back to the main selection of installed modules/guns, but when you do fulton the equip button is not there, just minor QoL, but makes it so you have to full back then go into equip again.

Thanks for the report. All that should be addressed now too. I'll note however the medevac interaction will just move the dropship over the stretcher and set the camera; hoisting still requires manual interaction.