Fixes Nuke failing to detonate #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
approved these changes
Dec 30, 2023
|
Was able to reproduce and confirm it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Under very specific circumstances (seen 2x or more on live), the nuke broken logic of checking eligbile mobs for explosion will cause it to crash completely and fail to detonate. The problem is primarily the
loccheck at top, which is not a sufficient safeguard.Also moves the explosion delay so that people die when the nuke explode and not before...
Testing Photographs and Procedure
Spawn in nuke and testers, safety off, proccall explode
Changelog
🆑
fix: Fixed Nuke failing to detonate under specific circumstances. It may involve a little rodent.
fix: Nuke explosion will now kill mobs on its actual explosion rather than at the start of the cinematic sequence.
/:cl: