Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eggs are now properly converted to forsaken on evac #5340

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Dec 29, 2023

About the pull request

half of #4376
eggs now become forsaken on hijack, like everything else. tested and it works.

Explain why it's good for the game

bugs should be fixed

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Private Tristan
fix: Eggs are properly converted to Forsaken hive on evac
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 29, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine and appears to work:

image

@Drulikar Drulikar added this pull request to the merge queue Dec 31, 2023
Merged via the queue into cmss13-devs:master with commit 192e412 Dec 31, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 31, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2024
# About the pull request
the other half of #5340, fixes #4376 
Tunnels are now forsaken!
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

Forsaken xenos should be able to use tunnels

# Testing Photographs and Procedure
<details>
<summary>Open me for testing</summary>


https://github.com/cmss13-devs/cmss13/assets/54422837/25f7ce72-0773-4bce-896a-800054d6b232



https://github.com/cmss13-devs/cmss13/assets/54422837/e4954940-f39e-4bda-9756-5f8da3dcc6a0



</details>


# Changelog
:cl:
fix: Tunnels are now converted to forsaken on evac.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants