Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TWE to ERT rotation #5351

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Dec 31, 2023

About the pull request

Adds the Three-World ERT as a possible distress beacon response with chances slightly lower than other common (UPP, PMC, etc.) ERTs.

Explain why it's good for the game

The TWE ERT seems to be fairly complete and has been sitting largely unused in the code for several months. More sensible variation in distress beacons is good.

Changelog

🆑
add: The Three-World Empire will now occasionally respond to distress beacons.
/:cl:

@Zonespace27 Zonespace27 added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. labels Dec 31, 2023
@github-actions github-actions bot added the Feature Feature coder badge label Dec 31, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks fine and can confirm the ERT works (manually called).

@Drulikar Drulikar added this pull request to the merge queue Jan 1, 2024
Merged via the queue into cmss13-devs:master with commit 3a409b8 Jan 1, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants