Lesser drones and facehuggers cannot speak for 3 minutes after spawning #5352
Conversation
Zonespace27
added
Balance
code/modules/mob/living/carbon/xenomorph/castes/lesser_drone.dm
Outdated
Show resolved
Hide resolved
|
This is a great change thank you, but i feel like pointing and any other acts of grabbing attention can still lead to this. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
| if(parent) | ||
| to_chat(parent, SPAN_NOTICE(on_unmute_message)) | ||
| UnregisterSignal(parent, COMSIG_LIVING_SPEAK) | ||
| UnregisterFromParent(parent, COMSIG_XENO_TRY_HIVEMIND_TALK) |
There was a problem hiding this comment.
I think you meant UnregisterSignal() as this causes an infinite loop but otherwise looks good.
| @@ -63,15 +63,21 @@ | |||
| weed_food_icon = 'icons/mob/xenos/weeds_48x48.dmi' | |||
| weed_food_states = list("Facehugger_1","Facehugger_2","Facehugger_3") | |||
| weed_food_states_flipped = list("Facehugger_1","Facehugger_2","Facehugger_3") | |||
| /// The last ckey to have inhabited this mob | |||
| var/last_ckey_inhabited = "" | |||
There was a problem hiding this comment.
Is this not redundant to persistent ckey?
|
This likely also needs to affect #5496 if that is merged. |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
…ns (#5688) # About the pull request This PR revives and expands #5352. By expand I mean that in addition to a 3 minute restriction for say and hivemind speak, custom emotes and pointing are also restricted during the 3 minute window. Past that I did some additional refactoring. # Explain why it's good for the game As a ghost role, this acts as a measure to mechanically limit the communication of meta info to other members in the hive. For now the restriction is only 3 minutes. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>  </details> # Changelog :cl: Zonespace Drathek balance: Lesser drones and Facehuggers cannot speak, custom emote, or point for 3 minutes after spawning /:cl: --------- Co-authored-by: John Doe <[email protected]>
About the pull request
Lessers and facehuggers are unable to speak (locally and hivemind) for 3m after spawning.
Explain why it's good for the game
The ability for ghosts to spawn as instant, cheap xenos has caused a noticeable uptick in bad faith players abusing the system. This delay means that lessers and huggers will be less able to spawn in and immediately announce marine pushes, flanks, etc. while still allowing the high-effort ones the ability to communicate and RP once they've lived long enough to invalidate most of the metainfo they had.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
balance: Lesser drones and facehuggers cannot speak for 3 minutes after spawning.
/:cl: