Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missing bitfields for VV #5369

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jan 2, 2024

About the pull request

This PR simply updates the bitfield defines used to parse bitfield numbers in the variable viewer as text. The biggest reason for this PR is to support vis_flags that I frequently need to fiddle with.

This isn't an exhaustive look at all bitfields we may have defined. Feel free to request any others and I can also add them.

Explain why it's good for the game

Fixes
image
And editing it is simply a number
image

Testing Photographs and Procedure

Screenshots & Videos

image
image
image
image
image

Changelog

🆑 Drathek
code: Add missing bitfield definitions for variable viewer (VV)
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jan 2, 2024
@realforest2001
Copy link
Member

Only one I can think to add is vision_flags which should use the same as sight as it's used to update sight from glasses

@Drulikar
Copy link
Contributor Author

Drulikar commented Jan 3, 2024

image
vision_flags now too

@realforest2001 realforest2001 added this pull request to the merge queue Jan 6, 2024
Merged via the queue into cmss13-devs:master with commit 55bd564 Jan 6, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 6, 2024
@Drulikar Drulikar deleted the Update_Bitfields branch January 8, 2024 22:58
FslashN added a commit to FslashN/CMSS13-PvE-Test that referenced this pull request May 2, 2024
Ports changes from cmss13-devs/cmss13#5369 and makes other bitfield changes based on changes requested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants