Distress beacon response messages now have a chance of being static #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 6, 2024
Birdtalon
suggested changes
Jan 8, 2024
| @@ -28,6 +28,8 @@ | |||
| var/mob_min = 3 | |||
| var/dispatch_message = "An encrypted signal has been received from a nearby vessel. Stand by." //Msg to display when starting | |||
| var/arrival_message = "" //Msg to display about when the shuttle arrives | |||
| var/chance_hidden = 20 | |||
There was a problem hiding this comment.
Suggested change
| var/chance_hidden = 20 | |
| /// Probability that the message will be replaced with static. - prob(chance_hidden) | |
| var/chance_hidden = 20 |
| @@ -28,6 +28,8 @@ | |||
| var/mob_min = 3 | |||
| var/dispatch_message = "An encrypted signal has been received from a nearby vessel. Stand by." //Msg to display when starting | |||
| var/arrival_message = "" //Msg to display about when the shuttle arrives | |||
| var/chance_hidden = 20 | |||
| var/static_message = "**STATIC** %$#&!- *!%^#$$ ^%%$# +_!@* &*%$## **STATIC** &%$#^*! @!*%$# ^%&$#@ *%&$#^ **STATIC** --SIGNAL LOST" //Msg to display when distress beacon is hidden | |||
There was a problem hiding this comment.
Suggested change
| var/static_message = "**STATIC** %$#&!- *!%^#$$ ^%%$# +_!@* &*%$## **STATIC** &%$#^*! @!*%$# ^%&$#@ *%&$#^ **STATIC** --SIGNAL LOST" //Msg to display when distress beacon is hidden | |
| /// Message to display when distress beacon is hidden | |
| var/static_message = "**STATIC** %$#&!- *!%^#$$ ^%%$# +_!@* &*%$## **STATIC** &%$#^*! @!*%$# ^%&$#@ *%&$#^ **STATIC** --SIGNAL LOST" |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
…5757) # About the pull request Revives this PR. #5393 Adds a probability of (20) for the distress beacon response message to be full of static and therefore not decipherable. # Explain why it's good for the game Part of the fun of distress beacons was not knowing who's going to show up to your door. This brings that back, to an extent. Less of 'Oh no it's hostile UPP!!' over radio as soon as distress is received. # Changelog :cl: add: Implemented a probability of playing a static-filled transmission as the distress received response. /:cl: Co-authored-by: Jeff Watchson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prob(20) chance for the distress beacon response message to be full of static and therefore not decipherable.
Explain why it's good for the game
Part of the fun of distress beacons was not knowing who's going to show up to your door. This brings that back, to an extent. Less of 'Oh no it's hostile UPP!!' over radio as soon as distress is received.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Implemented a probability of playing a static-filled transmission as the distress received response.
/:cl: