Hive collapse when less than 4 xenos is still a marine major. #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Birdtalon
approved these changes
Jan 24, 2024
cm13-github
added a commit
that referenced
this pull request
Jan 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 31, 2024
# About the pull request Fixes a runtime in `/datum/game_mode/colonialmarines/check_queen_status()` which was stopping the 'Marine Minor' round result (Hive collapse) from being set. (Added by a tiny mistake in #5442) ``` runtime error: type mismatch: cannot compare /list (/list) to 3 - proc name: check queen status (/datum/game_mode/colonialmarines/check_queen_status) - source file: code/game/gamemodes/colonialmarines/colonialmarines.dm,335 - usr: null - src: Distress Signal (/datum/game_mode/colonialmarines) - call stack: - Distress Signal (/datum/game_mode/colonialmarines): check queen status("xeno_hive_normal") ``` The `totalXenos` list itself was being compared to the number instead of the list's length, which aborted the proc before `round_finished` could be set. I've gone through all of this year's game logs just to double check, and there hasn't been a 'Marine Minor Victory' since the 24th of January. # Explain why it's good for the game Marines get a slightly worse victory condition again. (woo!) # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: Fixed a runtime error preventing a 'Marine Minor' (Hive collapse) roundend state. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Why below 4 xenos? Because 15 xenos without a Queen is still a threat, 3 xenos can easily be killed.
(I don't like chasing lurkers down for 5 minutes after everyone else is dead)
Explain why it's good for the game
I must have my Marine Major, not this silly Marine Minor. A single lurker being alive isn't a big deal
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: A hive collapse (No new Queen) while at 3 xenos or below is now a marine major, instead of a minor.
/:cl: