Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Typo Fix and Sprite Refactor #5489

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

ItsVyzo
Copy link
Contributor

@ItsVyzo ItsVyzo commented Jan 18, 2024

About the pull request

fixes small typo and makes spriter life easier long-term

Explain why it's good for the game

Makes life easier

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 LTNTS
fix: removed the tiny square in the MP beret to stop it looking like a french mime's beret
refactor: reorganized cm_hats and cm_suits for easier spriter usage
spellcheck: fixed area typo Marshall to Marshal
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Fix Fix one bug, make ten more Refactor Make the code harder to read Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Jan 18, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jan 21, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 29, 2024
@Drulikar Drulikar added this pull request to the merge queue Jan 30, 2024
Merged via the queue into cmss13-devs:master with commit 8561810 Jan 30, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 30, 2024
@ItsVyzo ItsVyzo deleted the misc_fixes branch January 31, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Refactor Make the code harder to read Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants