Fixes the do_after() icon rendering above everything else
#5491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes the
do_after()progress icons rendering above everything else, including darkness and screen effects like blindness.When making #5379, I didn't consider the side effects of the progress icons being on
ABOVE_HUD_PLANE. It works fine on other servers where they're usually only visible to the user performing the action, but on CM these icons are visible to everyone.This means that progress indicators over mobs are visible in complete darkness, through crit/blindness overlays, etc.
This PR adds a new
ABOVE_GAME_PLANEdefine and moves them to that instead, since it seems like the best fit for how the progress icons should behave. (Always above in-game stuff, but below any effects and lighting.)(I've never messed with plane masters so I'm not 100% sure I did it correctly, but it works in testing at least.)
Explain why it's good for the game
Fixes being able to spot xenos in darkness when they're doing something (e.g. drones building), and just makes it act as expected.
Testing Photographs and Procedure
Screenshots & Videos
Before:
(not much point to an 'after' since it's just a black screen lol)
Changelog
🆑
fix: Fixed the 'busy' circle icon being drawn above darkness and screen effects.
/:cl: