Gardener QOL changes #5514
Merged
Gardener QOL changes #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Quality of Life
Birdtalon
added
Balance
Birdtalon
approved these changes
Jan 24, 2024
Drulikar
requested changes
Jan 31, 2024
Drulikar
added
the
Balance Approved
Drulikar
requested changes
Feb 1, 2024
Co-authored-by: Drathek <[email protected]>
Co-authored-by: Drathek <[email protected]>
Drulikar
approved these changes
Feb 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2024
# About the pull request This PR is a follow up to #5514 where we set picked true to have more accurate messages sent, however this was also checked to skip updating the fruit count in the bound_xeno's action. This PR also refactors out delete_fruit since it just effectively was Destroy anyways. # Explain why it's good for the game Fixes #5666 # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/4020e86d-df91-4d44-aaf5-0a338584cbc2 </details> # Changelog :cl: Drathek fix: Fix gardener fruit count not always updating /:cl: --------- Co-authored-by: Birdtalon <[email protected]>
Guidesu
pushed a commit
to Guidesu/cmss13
that referenced
this pull request
Feb 10, 2024
This PR is a follow up to cmss13-devs#5514 where we set picked true to have more accurate messages sent, however this was also checked to skip updating the fruit count in the bound_xeno's action. This PR also refactors out delete_fruit since it just effectively was Destroy anyways. Fixes cmss13-devs#5666 <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/4020e86d-df91-4d44-aaf5-0a338584cbc2 </details> :cl: Drathek fix: Fix gardener fruit count not always updating /:cl: --------- Co-authored-by: Birdtalon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Gives bigger fruit eaten/destroyed/picked texts as its currently too small to be seen in chat because is usually always moving and being spammed.
Makes it so you can put fruits next to eachother, but not ontop of eachother.
Lets the player know you can use resin surge to speed up the growth of the fruits.
eaten fruits now delete faster so you can replace them faster, the old 3 seconds made it so if you ate a fruit and instantly replaced it at max fruits, it'd rather delete another one because the eaten fruit still exited for a whole 3 seconds.
Explain why it's good for the game
QOL changes good
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
qol: Bigger text when a gardener's fruit gets picked/destroyed/consumed
qol: Gardeners can now put their fruits next to eachother.
grammar: Adds new information to the strain buy text
code: The fruits now get deleted 1 second after they get eaten, instead of 3 seconds.
balance: Gardener can now transfer plasma
fix: Properly gives the corresponding message when you eat a fruit from the ground, now "consumed" instead of "destroyed"
/:cl: