Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds One ACCESSORY ONLY Slot for Helmets #5573

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

Staykeu
Copy link
Contributor

@Staykeu Staykeu commented Jan 27, 2024

About the pull request

Allows for the insertion of an extra cosmetic item in helmets that subtype the M10.

Explain why it's good for the game

Adds more personalization to people who don the helmet. Change is purely cosmetic.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Stakeyng
qol: Lets you put an extra accessory item in your helmet.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jan 27, 2024
@BeagleGaming1
Copy link
Contributor

How is it qol? And could you be more descriptive on the changelog rather than just "Customization"

@Staykeu
Copy link
Contributor Author

Staykeu commented Jan 27, 2024

How is it qol? And could you be more descriptive on the changelog rather than just "Customization"

Everything else is written down, customization is all that I felt needed to be stated.

It's QOL because it allows for a more personalized character when you use the helmet. I stated that.

@BeagleGaming1
Copy link
Contributor

The changelog is what will be player facing, what people can see in game. People seeing just "Customization" or "allow for a more personalized experience during gameplay" on the ingame changelog or on the discord channel won't understand what that means.

@Staykeu
Copy link
Contributor Author

Staykeu commented Jan 27, 2024

The changelog is what will be player facing, what people can see in game. People seeing just "Customization" or "allow for a more personalized experience during gameplay" on the ingame changelog or on the discord channel won't understand what that means.

It's changed now.

@567Turtle
Copy link
Contributor

567Turtle commented Jan 29, 2024

I would probably make it so the helmets have three (3 (III)) slots for garb since this has next to no effect on gameplay, its just extra drip.

@Birdtalon Birdtalon added Feature Feature coder badge and removed Quality of Life Make the game harder to play labels Jan 29, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 10, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 12, 2024
Merged via the queue into cmss13-devs:master with commit ebafd17 Feb 12, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 12, 2024
@Staykeu Staykeu deleted the helmet-accessories branch September 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants