Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vamp lurker Tweaks #5625

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Vamp lurker Tweaks #5625

merged 4 commits into from
Feb 18, 2024

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Feb 1, 2024

About the pull request

-Using Tail stab on the same tile a enemey is standing will automatically target tailstab to the enemy.
-Sprite clicking and enemy with Tail stab now provides a Bonus 15 Dmg

Explain why it's good for the game

after the reversal of the vamp lurker rework it was left in a very weak state . only a handfull of players being able to play it decently. this PR aims to make it a little easier for players to use vamp lurker.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Tail Jab will now target enemies on the same tile it was targeted.
balance: Aiming Tail Jab directly on a target will do an additional 15 damage
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 1, 2024
@Nanu308
Copy link
Member

Nanu308 commented Feb 2, 2024

From fighting vampires in game personally, and seeing them play I would say they do not need buffs at all, but rather maybe a few tweaks/nerfs. They are incredibly fast and have CC as well as good damage output, i will say that yeah, they can be hard to play sometimes, but, when a competent player gets into its shoes they do incredibly well.

I don't really see the reason for these buffs, I'd rather tweak vampire to be easier to play for the average player and then nerf its capabilities similar to what we did to warriors.

@Diegoflores31
Copy link
Contributor Author

From fighting vampires in game personally, and seeing them play I would say they do not need buffs at all, but rather maybe a few tweaks/nerfs. They are incredibly fast and have CC as well as good damage output, i will say that yeah, they can be hard to play sometimes, but, when a competent player gets into its shoes they do incredibly well.

I don't really see the reason for these buffs, I'd rather tweak vampire to be easier to play for the average player and then nerf its capabilities similar to what we did to warriors.

Compared to other T2s vamp lurker cant really 1 shot marines into crit . And this change is mostly about the aim assist which is to make it a little easier to play.
There is in fact one or two players that are very skilled but as far as i know we dont balance the entire caste just because 2 primes play it good

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 11, 2024
@Drulikar Drulikar marked this pull request as draft February 12, 2024 00:41
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Feb 16, 2024
@Diegoflores31 Diegoflores31 marked this pull request as ready for review February 18, 2024 05:55
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 18, 2024
@Drulikar Drulikar marked this pull request as draft February 18, 2024 06:51
@Diegoflores31 Diegoflores31 marked this pull request as ready for review February 18, 2024 08:19
@Drulikar Drulikar added this pull request to the merge queue Feb 18, 2024
Merged via the queue into cmss13-devs:master with commit c5e70e8 Feb 18, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 20, 2024
# About the pull request

This PR corrects an erroneous change in `apply_strain` because only
modifiers can be set here. The change to lower the damage tier would be
undone when `recalculate_damage` would apply the lurker caste's values
for the upper and lower damage values.

Ultimately I'm not certain it does need the damage reduction - but as of
#5625 it does more with direct tail stabs so between the two this should
be a minor nerf.

# Explain why it's good for the game

Corrects an intended reduction in damage for taking the strain.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>

# Changelog
:cl: Drathek
balance: Corrected vampire lurker damage values (Effectively reduction
by 5 damage for most attacks)
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants