Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pizza ERT readded, fixes(?) UPP spawn chance #5662

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Feb 4, 2024

About the pull request

Pizza ERT now has a 1 prob chance to spawn.
UPP ERT variants now have their prob set to 0 (they were inheriting prob 20) so UPP had 3 prob20 rolls instead of 1.
note: basic UPP ert text is always scrambled, regardless of whether they're hostile or not, the friendly text will only show up if an admin forces a friendly UPP ERT to appear.

Explain why it's good for the game

Pizza ERT was a funny (and incredibly rare) occurrence that got removed when #2318 was added. with prob 1 it's incredibly unlikely to roll, (roughly 1 in 146 distress beacons) meaning that the one time that it does occur that will likely be memorable to every ghost in dchat (and marines too, if the pizza manages to get delivered)

UPP prob change was (presumably) unintended and led to UPP being incredibly likely to roll compared to any other ERT.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Pizza ERT is back, although incredibly unlikely to occur
fix: UPP ERT no longer rolls 3 times (1 for random, 1 for friendly, and 1 for hostile), due to this, UPP comms will always be scrambled at the beginning, no way to tell intentions before meeting.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Fix Fix one bug, make ten more labels Feb 4, 2024
@BeagleGaming1
Copy link
Contributor

Why re-introduce the pizza ERT in a fix PR?

@private-tristan
Copy link
Contributor Author

discovered the UPP spawn chance was bugged while making the pizza ERT, decided to just fix it while I was there.
if the pizza ERT gets denied then i'll just delete that part and have the PR just be a fix

Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@Birdtalon Birdtalon added this pull request to the merge queue Feb 9, 2024
Merged via the queue into cmss13-devs:master with commit c1e9529 Feb 10, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants