-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperating every port and starboard hallway areas into three areas each (fore midship aft) #5699
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine now
About the pull request
1-Main idea is to split each Hallway area port and starboard into three areas.(fore midship aft)
2-Clean up the map to remove emergency shutter that are not acting as a frontier between areas.
3-removed unused areas.
4-rebuild structure of hallway area to have /lower and /upper areas.
Explain why it's good for the game
1-Mainly good to allow better use of health monitor.
2-trying to standardize how emergency shutter are placed on the almayer
3-4 are refactor with no impact on player.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
maptweak: split each Hallway area port and starboard into three areas.(fore midship aft)
maptweak: change the area around north and south west staircase to remove emergency shutters.
maptweak: change the area west of squad preparation room to remove emergency shutter.
maptweak: change the area west of lower engi to make emergency shutter be at the frontier of the area.
/:cl: