Xeno strains unit test #5725
Merged
Xeno strains unit test #5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
This reverts commit e905a21.
|
damn, there had to be something |
Not actually caused by the PR, just discovered by it. (hooray I guess?) Basically when the tacmap action was removed by a strain (with a new one added later), the `COMSIG_HIVE_NEW_QUEEN` signal on it never got unregistered and it sorta got left floating in nullspace until a new queen comes along to cause a runtime. There should really be a unit test for this problem, but that's out of scope for now. (Although I did pre-emptively fix /datum/action/minimap in case it ever has the same problem)
harryob
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds a unit test for xeno strains.
I could have included this in #5542, but I thought it would be better in its own PR in order to keep the checks and everything separate.
The removed sprites for the Trapper, Charger, Gardener, and Watcher strains are (as far as I'm able to tell) completely identical to that of the base caste, and are only there in order to make the old system work properly.
Currently, this includes the following tests:
caste_typevariable on each/mob/living/carbon/xenomorphsubtype has a corresponding entry inGLOB.xeno_datum_list. (Not really strain related but I figured no harm in including it)/datum/xeno_strainsubtype has its ownnameanddescription.actions_to_addandactions_to_removelists are added and removed from the xeno properly. (Taking into account any which are re-added.)behavior_delegate_typeis successfully added to the xeno.icon_state_prefix, going through the xeno'siconfile and double checking that there aren't strain sprites in there (That is, sprites beginning with the strain's name). If there are any, thenicon_state_prefixshould probably be set to use them.icon_state_prefix, making sure that the xeno's sprite actually got changed to the strain version.Explain why it's good for the game
More unit tests! (woo)
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
code: Added a unit test for xeno strains.
/:cl: