Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xeno strains unit test #5725

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Xeno strains unit test #5725

merged 4 commits into from
Feb 19, 2024

Commits on Feb 15, 2024

  1. Unit test

    @SabreML
    SabreML committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ce15cbb View commit details
    Browse the repository at this point in the history

  2. Unit test tests

    @SabreML
    SabreML committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e905a21 View commit details
    Browse the repository at this point in the history

  3. Revert "Unit test tests" 

    This reverts commit e905a21.
    @SabreML
    SabreML committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b3d801d View commit details
    Browse the repository at this point in the history

  4. Tacmap ability fix 

    Not actually caused by the PR, just discovered by it. (hooray I guess?)

Basically when the tacmap action was removed by a strain (with a new one added later), the `COMSIG_HIVE_NEW_QUEEN` signal on it never got unregistered and it sorta got left floating in nullspace until a new queen comes along to cause a runtime.
There should really be a unit test for this problem, but that's out of scope for now.

(Although I did pre-emptively fix /datum/action/minimap in case it ever has the same problem)
    @SabreML
    SabreML committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    574e9b9 View commit details
    Browse the repository at this point in the history