Tactical Compact Nailgun #5746

MobiusWon · 2024-02-18T02:24:46Z

About the pull request

This PR adds the tactical compact nailgun to the 'essential engineer kit'.

Explain why it's good for the game

~~Light replacer being an essential item is a leftover from a bygone (2016) era in CM, it's time to replace it with something far more useful...~~ behold! the Tactical Compact Nailgun, coming to engineer preps near you!

Engineers have a capability gap with critical cades, they only have two options: wait for it to be destroyed or deconstruct it. Both of these options leave a hole in the defensive line.
Giving them the tactical compact nailgun covers the capability gap with a third option: return the cade to a repairable state at a high cost. The cost is subject to change, but right now 4 2 metal sheets are spent per repair(civilian nailgun default is 1 sheet).
The tactical compact nailgun will allow an engineer, in an ideal case, to save 12 24 cades with one mag. There are 48 nails per magazine (it spawns with one loaded mag) and each repair cost 4 nails and 2 material. Material will be the likely limiting factor for repairs, therefore in practice the tactical nailgun is likely to only be used for emergency repairs during FOB Defense.
This grants the marines a new tactical capability without affecting the usefulness of a civilian model nailgun.

~~5. For those who still take the light replacer (for some crazy reason) it is now found in the engineer tool vendor.~~

Note: it is skill locked to SKILL_ENGINEER_ENGI level+

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑 NervanCatos
add: Adds tactical compact nailgun as an essential item for combat technicians
balance: material required to repair with tactical compact nailgun is 2 instead of the normal 1
refactor: refactors nailgun checks into a better order and other small things
imageadd: adds icons for tactical compact nailgun
/:cl:

nauticall

sprites yuh

fira

Some things such as mat_tac should be refactored to be handled by the nailguns, rather than using istype checks

code/game/objects/structures/barricade/barricade.dm

Steelpoint · 2024-02-23T12:08:30Z

Thematically it might be odd that a military issued nailgun is extremely inefficient and limited in use compared to a civilian issued nailgun.

cm13-github · 2024-02-23T20:22:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github · 2024-02-27T04:27:35Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

MobiusWon · 2024-02-27T04:39:01Z

Thematically it might be odd that a military issued nailgun is extremely inefficient and limited in use compared to a civilian issued nailgun.

From a thematic standpoint this could be explained in a few ways:

USCM SOP could dictate that 4 2 metal sheets be used per repair for barricades, whereas civilians just make do with what they have.
It's military grade, meaning it sacrifices comfort and efficiency for durability and ease of repair.
"Panicking" using more material than normal for [reason]

Drulikar

I don't really think this is a tool worth taking. Its devours your materials for little benefit. Its also weird to require nailgun magazines in addition to the sheets. Where should they acquire more nailgun mags? And would anyone even want that wasted inventory space? Nailgun mags likely need to be refilled with metal rods or something. Comtechs tend to have little inventory to work with if they want any combat tools too.

code/game/objects/structures/barricade/barricade.dm

code/game/machinery/vending/vendor_types/squad_prep/squad_engineer.dm

code/game/objects/structures/barricade/barricade.dm

code/modules/projectiles/guns/smgs.dm

Drulikar · 2024-02-28T10:43:18Z

Also the empty mags it spits out examine with this:

code/modules/projectiles/guns/smgs.dm

Co-authored-by: Drathek <[email protected]>

github-actions · 2024-03-07T00:49:43Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

cm13-github · 2024-05-15T03:17:16Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Drulikar · 2024-05-15T03:31:37Z

Single argument round should be floor now.

MobiusWon · 2024-05-20T01:49:22Z

Also the empty mags it spits out examine with this:

Resolved

MobiusWon · 2024-05-20T01:54:01Z

I don't really think this is a tool worth taking. Its devours your materials for little benefit. Its also weird to require nailgun magazines in addition to the sheets. Where should they acquire more nailgun mags? And would anyone even want that wasted inventory space? Nailgun mags likely need to be refilled with metal rods or something. Comtechs tend to have little inventory to work with if they want any combat tools too.

mat_tac reduced from 4 to consuming 2 sheets.
Nailgun mags added the squad prep & requisitions

cm13-github · 2024-05-20T02:04:07Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

MobiusWon · 2024-05-20T02:24:30Z

Single argument round should be floor now.

Resolved

github-actions · 2024-05-28T01:05:05Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Drulikar · 2024-06-03T15:12:44Z

Marking as stale exempt for now so it is more prioritized in my tracker.

Drulikar

Only other outstanding issue I think is that there is no correct state when holstered (at least in this pouch /obj/item/storage/belt/gun/utility for both compact and tactical compact)

Drulikar · 2024-06-03T17:53:53Z

code/game/objects/structures/barricade/barricade.dm

 		return FALSE

 	var/repair_value = 0
 	for(var/validSheetType in repair_materials)
-		if(validSheetType == material.sheettype)
+		if(!isnull(material) && validSheetType == material.sheettype)


This runtimes if wield the nailgun and use it on a barricade.

cm13-github · 2024-06-14T08:54:28Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Git-Nivrak · 2024-07-07T16:00:49Z

#6650

Zonespace27 · 2024-07-16T13:32:59Z

Closing since PR seems to have had no changes for about a month and a half while drafted. Ping a maint if you want this reopened

MobiusWon added 2 commits February 17, 2024 19:52

tacticool_nailgun

7eaac18

desc wording

b72548a

github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Refactor Make the code harder to read labels Feb 18, 2024

nauticall approved these changes Feb 19, 2024

View reviewed changes

nauticall added the Sprites Approved confirmed no stray pixels label Feb 19, 2024

fira requested changes Feb 19, 2024

View reviewed changes

code/game/objects/structures/barricade/barricade.dm Outdated Show resolved Hide resolved

code/game/objects/structures/barricade/barricade.dm Outdated Show resolved Hide resolved

code/game/objects/structures/barricade/barricade.dm Show resolved Hide resolved

MobiusWon marked this pull request as draft February 21, 2024 04:33

MobiusWon and others added 3 commits February 21, 2024 17:29

Merge branch 'master' into tactical_nailgun

5428f9d

tweaks

1e5442d

build icon

7b8ca34

MobiusWon marked this pull request as ready for review February 22, 2024 02:07

MobiusWon requested a review from fira February 22, 2024 02:07

cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Feb 23, 2024

MobiusWon marked this pull request as draft February 23, 2024 23:52

MobiusWon marked this pull request as ready for review February 27, 2024 01:43

Merge remote-tracking branch 'upstream/master' into tactical_nailgun

fa1ecef

cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Feb 27, 2024

Drulikar requested changes Feb 28, 2024

View reviewed changes

Drulikar reviewed Feb 28, 2024

View reviewed changes

code/modules/projectiles/guns/smgs.dm Show resolved Hide resolved

Drulikar marked this pull request as draft February 28, 2024 10:48

Update code/game/objects/structures/barricade/barricade.dm

4049366

Co-authored-by: Drathek <[email protected]>

resurrection

522d994

cm13-github added the Merge Conflict PR can't be merged because it touched too much code label May 15, 2024

github-actions bot removed the Stale beg a maintainer to review your PR label May 16, 2024

the nailguning

27a91cb

gitMerge branch 'master' into tactical_nailgun

adfc25d

cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label May 20, 2024

floor

89744cd

MobiusWon marked this pull request as ready for review May 20, 2024 02:19

MobiusWon requested a review from Drulikar May 20, 2024 02:19

github-actions bot added the Stale beg a maintainer to review your PR label May 28, 2024

Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jun 3, 2024

Drulikar requested changes Jun 3, 2024

View reviewed changes

Drulikar marked this pull request as draft June 3, 2024 17:54

cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jun 14, 2024

hislittlecuzingames mentioned this pull request Jul 7, 2024

Com Tech Specializations #6636

Closed

Zonespace27 closed this Jul 16, 2024

Drulikar mentioned this pull request Aug 1, 2024

Comtech Stuff #6650

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tactical Compact Nailgun #5746

Tactical Compact Nailgun #5746

MobiusWon commented Feb 18, 2024 •

edited

Loading

nauticall left a comment

fira left a comment

Steelpoint commented Feb 23, 2024

cm13-github commented Feb 23, 2024

cm13-github commented Feb 27, 2024

MobiusWon commented Feb 27, 2024 •

edited

Loading

Drulikar left a comment

Drulikar commented Feb 28, 2024

github-actions bot commented Mar 7, 2024

cm13-github commented May 15, 2024

Drulikar commented May 15, 2024

MobiusWon commented May 20, 2024

MobiusWon commented May 20, 2024

cm13-github commented May 20, 2024

MobiusWon commented May 20, 2024

github-actions bot commented May 28, 2024

Drulikar commented Jun 3, 2024

Drulikar left a comment

Drulikar Jun 3, 2024

cm13-github commented Jun 14, 2024

Git-Nivrak commented Jul 7, 2024

Zonespace27 commented Jul 16, 2024

Tactical Compact Nailgun #5746

Tactical Compact Nailgun #5746

Conversation

MobiusWon commented Feb 18, 2024 • edited Loading

About the pull request

Explain why it's good for the game

Testing Photographs and Procedure

Changelog

nauticall left a comment

Choose a reason for hiding this comment

fira left a comment

Choose a reason for hiding this comment

Steelpoint commented Feb 23, 2024

cm13-github commented Feb 23, 2024

cm13-github commented Feb 27, 2024

MobiusWon commented Feb 27, 2024 • edited Loading

Drulikar left a comment

Choose a reason for hiding this comment

Drulikar commented Feb 28, 2024

github-actions bot commented Mar 7, 2024

cm13-github commented May 15, 2024

Drulikar commented May 15, 2024

MobiusWon commented May 20, 2024

MobiusWon commented May 20, 2024

cm13-github commented May 20, 2024

MobiusWon commented May 20, 2024

github-actions bot commented May 28, 2024

Drulikar commented Jun 3, 2024

Drulikar left a comment

Choose a reason for hiding this comment

Drulikar Jun 3, 2024

Choose a reason for hiding this comment

cm13-github commented Jun 14, 2024

Git-Nivrak commented Jul 7, 2024

Zonespace27 commented Jul 16, 2024

MobiusWon commented Feb 18, 2024 •

edited

Loading

MobiusWon commented Feb 27, 2024 •

edited

Loading