Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comtech Stuff #6650

Merged
merged 6 commits into from
Aug 3, 2024
Merged

Comtech Stuff #6650

merged 6 commits into from
Aug 3, 2024

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Jul 7, 2024

About the pull request

A bunch of qol and new items for combat technicians

Explain why it's good for the game

Gives combat techs some new tools, toys and skills to make them feel like an actual role rather than another guy with engineering skill.

Sprite screenshots

305680653-a9a4818a-83c9-43cf-8a12-a21cc95de856
305680657-5f5f6226-448e-4196-8a20-983da8f718be

Changelog

🆑 Nivrak, NervanCatos
balance: Modified engineering skill levels, Combat technicians now do everything engineering related slightly faster. This does not affect any other roles or skillchecks.
add: Adds the tactical compact nailgun to the Combat Technician's vendor essential engineering kit, It cannot fire and uses 2 metal instead of 1 to repair. Credit to NervanCatos.
add: Added the M277 pattern construction rig, It comes with 6 slots instead of 10 in the M276 but can carry metal and plasteel stacks. Available in the CT vendor.
add: Added the Engineer Kit pouch, basically and engineer kit - in a pouch. Restricted by engineering skill. Available in the CT vendor.
add: Added the Small Tool Webbing, A smaller variant of the tool webbing with 6 slots instead of 7. Available in the CT vendor.
qol: Screwdriver, Crowbar, Blowtorch, Multitool, Wrench and Wirecutters will now prioritize the tool webbing when quick equipping.
code: Added a new variable for items, preferred_storage which allows to replicate the above behavior for other items and storages.
add: Added a new sentry upgrade, The omni-sentry. As the name suggests it is omni-directional but has 30% reduces damage and a shorter range by 1.
qol: Made APC examine-text a bit more clear about what you should be doing next.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Quality of Life Make the game harder to play Code Improvement Make the code longer labels Jul 7, 2024
@hislittlecuzingames
Copy link
Contributor

I like it.
Definitely makes Techs more convenient.

Though I think I'll miss not having specialized techs, in my PR, I don't think it'll be out of the question at a later date.
#6636

This is a better alteration to start with as it still keeps techs building.

@kooarbiter
Copy link

ok fine, do I need to sacrifice an MP on an altar to unga prime or bob the builder to get this PR pushed through?

also thank you

@blackdragonTOW
Copy link
Contributor

Hello! Please remember to attach screenshots of your altered sprites in the PR description!!

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 22, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 27, 2024
@Drulikar
Copy link
Contributor

stale exempt until reviewed

cm13-github added a commit that referenced this pull request Jul 28, 2024
@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jul 29, 2024
cm13-github added a commit that referenced this pull request Jul 30, 2024
cm13-github added a commit that referenced this pull request Jul 30, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Aug 1, 2024

Sprites are binary identical to #5746
image
So I will transfer sprite approval.

@Drulikar Drulikar added the Sprites Approved confirmed no stray pixels label Aug 1, 2024
code/modules/projectiles/guns/smgs.dm Outdated Show resolved Hide resolved
code/modules/projectiles/guns/smgs.dm Show resolved Hide resolved
code/game/objects/structures/barricade/barricade.dm Outdated Show resolved Hide resolved
code/modules/projectiles/guns/smgs.dm Show resolved Hide resolved
code/game/objects/items/storage/pouch.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_helpers.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_helpers.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_helpers.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft August 1, 2024 18:36
@Drulikar Drulikar removed the Stale Exempt PR can't go stale label Aug 1, 2024
@Git-Nivrak Git-Nivrak marked this pull request as ready for review August 2, 2024 09:09
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Aug 3, 2024
@Drulikar Drulikar added this pull request to the merge queue Aug 3, 2024
Merged via the queue into cmss13-devs:master with commit 6739ddc Aug 3, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Quality of Life Make the game harder to play Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants