Relay Ping Browser #5777
Merged
Relay Ping Browser #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
south america relay when? nice pr tho |
SabreML
reviewed
Feb 21, 2024
mullenpaul
reviewed
Feb 21, 2024
harryob
previously requested changes
Feb 22, 2024
Update layout Refactoring
…nmounted before a ping is started or finished
3 tasks
harryob
approved these changes
Feb 24, 2024
cm13-github
added a commit
that referenced
this pull request
Feb 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
…nt (#7474) # About the pull request This PR is a follow-up to #5777 and #6244 because Button.Confirm was changed how its confirm content was displayed. It used to display the children always, but TG since changed it to display either the confirm content or the children. Now the children will be displayed if there is no confirm content set. # Explain why it's good for the game Fixes confusing buttons in the ping relay browser. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Before:  After:  </details> # Changelog :cl: Drathek ui: Fixed the ping relay buttons not displaying anything when clicked on the first time. Now Button.Confirm.confirmContent will only replace children if it is truthy. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR adds a way to ping the relays and also easily connect to them. You can access this panel by clicking the ping near the top right of chat. The ping reported here will likely be inflated from what you will actually experience or see reported by TGChat (its highly dependent on how fast your computer runs the JavaScript, and is based only on a single ping per connection), but should still give an accurate relative difference between the different connections.
When the component is loaded, it starts a timer to begin the pings in 1 second. Whenever the component is unloaded, it indicates this to the ping javascript which will cause it to early return on any pending operations.
The configs are added to examples in relays.txt. You can include it in config.txt.
Explain why it's good for the game
This should give more visibility to the relays, provide an easy way to use them, and give more of an idea the differences in connection speeds to each relay.
Testing Photographs and Procedure
Random values during testing:
An actual test example (with last forced to time out):
Now with gauges:
Now with flex layout:
Changelog
🆑 Drathek
ui: Added the relay ping browser accessed by the tgchat ping to test and use alternative connections to the server
ui: Added onConfirmChange prop to Button.Confirm component.
config: Added CONNECTION_RELAY_PING and CONNECTION_RELAY_CON in the relays.txt config that is optionally included in config.txt
/:cl: