Spawn verb no longer DDOSes the server/user when called with nothing #5781
Conversation
| var/chosen | ||
| if(matches.len==1) | ||
| if(matches.len > 1) |
There was a problem hiding this comment.
Did you intend to change this from == to >?
harryob
changed the title
| @@ -182,12 +182,10 @@ | |||
| for(var/path in types) | |||
| if(findtext("[path]", object)) | |||
| matches += path | |||
|
|
|||
| if(matches.len==0) | |||
| if(matches.len==0 || matches == "" || matches == " ") | |||
There was a problem hiding this comment.
matches is a list, what is this trying to do
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Prevents admins from blowing up the server if they call the spawn proc with nothing.
There was a check for this,but it was ineffective.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 TotalEpicness5
fix: Fixed the admin spawn verb so it doesn't ddos the server if nothing is called with it.
/:cl: