Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawn verb no longer DDOSes the server/user when called with nothing #5781

Closed
wants to merge 1 commit into from
Closed

Spawn verb no longer DDOSes the server/user when called with nothing #5781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions code/modules/admin/admin.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,10 @@
for(var/path in types)
if(findtext("[path]", object))
matches += path

if(matches.len==0)
if(matches.len==0 || matches == "" || matches == " ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches is a list, what is this trying to do

return

var/chosen
if(matches.len==1)
if(matches.len > 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to change this from == to >?

chosen = matches[1]
else
chosen = tgui_input_list(usr, "Select an atom type", "Spawn Atom", matches)
Expand Down
Loading