Barricades Multi-Weld Revert & Refactoring #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring
Drulikar
added
the
Balance Approved
github-actions
bot
added
Balance
harryob
approved these changes
Feb 24, 2024
cm13-github
added a commit
that referenced
this pull request
Feb 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
# About the pull request This PR is a follow up to #5795 fixing a runtime should you swap to an empty hand during welding. This should be caught if we used `INTERRUPT_ALL` instead of `INTERRUPT_NO_NEEDHAND` but maybe multitasking something else like wire maybe was intended. # Explain why it's good for the game Fixes  # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/66e29f49-3696-401f-bd6c-da12e5d3cd71 </details> # Changelog :cl: Drathek fix: Fixed a runtime when swapping tools during cade welding /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a follow up to #5609 which removed a busy check from some barricades allowing multi-welding. This PR restores that setting (which is a return to normal for all but folding barricades which incorrectly allowed multi-welding before).
I have also added automatic looping to barricade welding if there is still work to be done, and it can be performed.
Explain why it's good for the game
The PR that introduced this change was not intended to be a balance change. Additionally, it's far more difficult to tune welding speeds if the quantity of barricades being welded at the same time is variable. Technically this is a nerf though because previously multi-welding folding barricades was possible.
Testing Photographs and Procedure
Screenshots & Videos
weld.mp4
After looping welding addition:
Untitled.mp4
Changelog
🆑 Drathek
add: Welding a barricade will now repeat automatically if it can still be repaired.
balance: Reverted multi-welding change to barricades: All barricades must be welded one at a time.
refactor: Refactored more barricade code.
/:cl: