Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speeds up ci runs by 3 minutes #5803

Merged
merged 1 commit into from
Feb 26, 2024
Merged

speeds up ci runs by 3 minutes #5803

merged 1 commit into from
Feb 26, 2024

Conversation

harryob
Copy link
Member

@harryob harryob commented Feb 24, 2024

closes #5679

@harryob harryob requested a review from fira as a code owner February 24, 2024 20:50
@harryob
Copy link
Member Author

harryob commented Feb 24, 2024

random pr before
image

now
image

@SabreML
Copy link
Member

SabreML commented Feb 25, 2024

Does this still allow the Nightmare subsystem to finish loading? (/datum/controller/subsystem/nightmare/proc/prepare_game() specifically)
As far as I know that's part of the reason it was acting strangely in the first place.

@Drulikar
Copy link
Contributor

Does this still allow the Nightmare subsystem to finish loading? (/datum/controller/subsystem/nightmare/proc/prepare_game() specifically) As far as I know that's part of the reason it was acting strangely in the first place.

Yes as far as I can see:
image
image

Using for example these:
image

image

@Drulikar Drulikar added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 26, 2024
Merged via the queue into cmss13-devs:master with commit 96c1dbc Feb 26, 2024
28 checks passed
@harryob harryob deleted the super-sanic-ci-opt branch April 10, 2024 16:49
@morrowwolf morrowwolf mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabreML SabreML SabreML approved these changes

@Drulikar Drulikar Drulikar approved these changes

@fira fira Awaiting requested review from fira fira is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test runs are waiting for the lobby timer to finish rather than skipping it
3 participants
@harryob @SabreML @Drulikar