Fix for crates and traps. #5835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This is essentially a revert of #3075.
Explain why it's good for the game
Firstly, I can challenge the basic idea of that PR. In my humble personal experience, when I pry apart crates (read: actually barrels), I am interested in their metal far more than in anything actually contained within. On the relatively rarer occasions involving actually prying crates of supplies for their contents, I am going to move the leftover planks of wood off the tile anyway - it does not make much difference whether they are on top or on bottom of the pile of supplies.
But more importantly, I have to question the execution. Messing with layers of items on the fly is not a good idea. It is even worse idea to extend it to all the movable atoms instead of simply items. I assume that the intent is to affect structures, but side effects of that allow an outright exploit. If you know, you know.
Some of the machinery crates can use a slight adjustment to make them look neater. I will probably get to that in a next PR once this one passes.
Changelog
🆑
fix: Removed an exploit involving crates.
/:cl: