-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor areas on Almayer in upper deck and tweak map a bit to reflect it. #5879
Conversation
fix some missing cleaning block north west stair. fix some disconnected pipes... NE engi upper.
i am not sure about west garden wall and window but didn't want to touch it to much. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
About the pull request
1-added a new hallway area to upper deck so that we have fore mid aft hallway.
2-added two new maintenance fore and aft and change placement of mid to make sense.
3-removed all the emergency shutter that weren't at the borders of each areas.
4-i added back the bear belt because it was deleted when it was move finding no real place to fit it in i settled for a closet in alpha/bravo dormitory
Explain why it's good for the game
1,2-make it easier to relocate and for maintenance it's part of a PR that will come after...
3-to standardize and make it way more clear how they are supposed to placed,used.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
refactor: refactored areas replaced stern hallway by aft added two new hallway area(fore, midship)
refactor: refactored areas replaced midship maintenance by for and added two new maintenance areas(fore, aft) with each starboard and port side.
maptweak: removed all the emergency shutter that weren't at the borders of each areas.
maptweak: added back the bear belt in a closet in a dormitory.
maptweak: reconnect some air pipe in an hallway north upper engi.
/:cl: