Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor areas on Almayer in upper deck and tweak map a bit to reflect it. #5879

Merged
merged 5 commits into from
Mar 16, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Mar 5, 2024

About the pull request

1-added a new hallway area to upper deck so that we have fore mid aft hallway.
2-added two new maintenance fore and aft and change placement of mid to make sense.
3-removed all the emergency shutter that weren't at the borders of each areas.
4-i added back the bear belt because it was deleted when it was move finding no real place to fit it in i settled for a closet in alpha/bravo dormitory

Explain why it's good for the game

1,2-make it easier to relocate and for maintenance it's part of a PR that will come after...
3-to standardize and make it way more clear how they are supposed to placed,used.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: refactored areas replaced stern hallway by aft added two new hallway area(fore, midship)
refactor: refactored areas replaced midship maintenance by for and added two new maintenance areas(fore, aft) with each starboard and port side.
maptweak: removed all the emergency shutter that weren't at the borders of each areas.
maptweak: added back the bear belt in a closet in a dormitory.
maptweak: reconnect some air pipe in an hallway north upper engi.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Refactor Make the code harder to read labels Mar 5, 2024
@Vicacrov
Copy link
Contributor

Vicacrov commented Mar 5, 2024

Nitpick, feel free to ignore it. The Upper Deck Starboard-Midship Maintenance APC and the Upper Deck Starboard Atmospherics APC are on the same wall, it makes that wall look a bit too busy. (It is only visible for observers and if you remove a wall between the two.)

image

fix some missing cleaning block north west stair.
fix some disconnected pipes... NE engi upper.
@Huffie56
Copy link
Contributor Author

Huffie56 commented Mar 6, 2024

i am not sure about west garden wall and window but didn't want to touch it to much.

@Huffie56 Huffie56 marked this pull request as ready for review March 6, 2024 10:41
@Huffie56 Huffie56 requested a review from Nanu308 as a code owner March 6, 2024 10:41
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 14, 2024
@Huffie56 Huffie56 added this to the USS Almayer Updates/Changes milestone Mar 15, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added this pull request to the merge queue Mar 16, 2024
@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Mar 16, 2024
Merged via the queue into cmss13-devs:master with commit 1882a1e Mar 16, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Mar 16, 2024
@Huffie56 Huffie56 deleted the almayer branch March 16, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Refactor Make the code harder to read Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants