Adds Shockwaves to Explosions and Xeno Screeches #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrrrKitten
changed the title
|
Very cool. |
Birdtalon
added
the
Testmerge Candidate
cm13-github
added a commit
that referenced
this pull request
Mar 19, 2024
3 tasks
cm13-github
added a commit
that referenced
this pull request
Mar 21, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 21, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 22, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 23, 2024
3 tasks
harryob
previously requested changes
Mar 25, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 26, 2024
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
cm13-github
added a commit
that referenced
this pull request
Mar 26, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 26, 2024
3 tasks
GrrrKitten
changed the title
cm13-github
added a commit
that referenced
this pull request
Mar 26, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 6, 2024
3 tasks
3 tasks
3 tasks
3 tasks
cm13-github
added a commit
that referenced
this pull request
Apr 7, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 7, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 7, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 7, 2024
|
Off TM for now |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Drulikar
requested changes
Apr 21, 2024
Drulikar
reviewed
Apr 21, 2024
Co-authored-by: Drathek <[email protected]>
Co-authored-by: Drathek <[email protected]>
Co-authored-by: Drathek <[email protected]>
|
tested and functional with the new commits |
Drulikar
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Mostly ported from TGMC via code from Ivanmixo + Tiviplus
Tested and very functional, only activates on explosions with above 150 power meaning:
notable would shockwave:
-yajuta casters
-HE rockets
-nuke
-pod decompresion
-CAS minirockets
-All OB's
-most OT nades
notable wouldnt shockwave:
-AP rockets
-Mateba HE
-plastic explosives
-sentry explosions
-HEDP's
-HEFA
-other tiny explosions
Also adds shockwaves to:
-Queen Screech (very large)
-Predalien Screech (smaller)
Explain why it's good for the game
Looks pretty cool, purely a VFX change via render plates. After extensively testing it for a few hours then going to play an actual round and seeing our OB's in their current state it was so sad.
Testing Photographs and Procedure
video had to be stupid compressed for github and also I cant crop it good cause photoshop said no more rendering today so have fun with this:
https://github.com/cmss13-devs/cmss13/assets/158611449/a83d26ea-3f7f-4053-8be4-d15ad707cdbc
Queen + Predalien Screech from 3 seperate POV's
screechtest3.2.mp4
Changelog
🆑
add: Adds shockwave VFX to powerful explosions
add: Adds shockwave VFX to Queen + Predalien screech
/:cl: