-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Shockwaves to Explosions and Xeno Screeches #5938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this is awesome
Very cool. |
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Off TM for now |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Co-authored-by: Drathek <[email protected]>
Co-authored-by: Drathek <[email protected]>
Co-authored-by: Drathek <[email protected]>
tested and functional with the new commits |
About the pull request
Mostly ported from TGMC via code from Ivanmixo + Tiviplus
Tested and very functional, only activates on explosions with above 150 power meaning:
notable would shockwave:
-yajuta casters
-HE rockets
-nuke
-pod decompresion
-CAS minirockets
-All OB's
-most OT nades
notable wouldnt shockwave:
-AP rockets
-Mateba HE
-plastic explosives
-sentry explosions
-HEDP's
-HEFA
-other tiny explosions
Also adds shockwaves to:
-Queen Screech (very large)
-Predalien Screech (smaller)
Explain why it's good for the game
Looks pretty cool, purely a VFX change via render plates. After extensively testing it for a few hours then going to play an actual round and seeing our OB's in their current state it was so sad.
Testing Photographs and Procedure
video had to be stupid compressed for github and also I cant crop it good cause photoshop said no more rendering today so have fun with this:
https://github.com/cmss13-devs/cmss13/assets/158611449/a83d26ea-3f7f-4053-8be4-d15ad707cdbc
Queen + Predalien Screech from 3 seperate POV's
screechtest3.2.mp4
Changelog
🆑
add: Adds shockwave VFX to powerful explosions
add: Adds shockwave VFX to Queen + Predalien screech
/:cl: