Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revives #5330: Desk Bells #5973

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Conversation

Waseemq1235
Copy link
Contributor

@Waseemq1235 Waseemq1235 commented Mar 18, 2024

Revives #5330.
Cooldown adjusted because I know how much of a headache a 1 second cooldown would give.
Credit:
Modified code and desk_bell.ogg from Paradise SS13
Sprite from Kat 'APC' Smith - darklordcabbage on discord. I just modified it a bit according to nauticall's review on the past PR.
Animated sprite from Thwomp. Also modified.
Birdtalon for the code.

Explain why it's good for the game

Grab req's attention without having to point at their floor.
Grab the offscreen WJ's attention.
Immersion?

Testing Photographs and Procedure

Screenshots & Videos

image
image

Changelog

🆑 Birdtalon, Kat 'APC' Smith, Thwomp, Waseemq1235
add: Desk bell for cargo, medbay, brig, and AI reception.
soundadd: Desk bell sound effect.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Sound Blast 5 minutes of bass boosted music to our players Feature Feature coder badge labels Mar 18, 2024
@Birdtalon
Copy link
Contributor

All permissions given freely by both original spriter and myself for this.

@Birdtalon
Copy link
Contributor

@Waseemq1235 please include a picture of the sprite in-game for sprite review. Cheers.

maps/map_files/USS_Almayer/USS_Almayer.dmm Outdated Show resolved Hide resolved
@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Mar 20, 2024
@Waseemq1235
Copy link
Contributor Author

@Waseemq1235 please include a picture of the sprite in-game for sprite review. Cheers.
Whole vid here

2024-03-21.21-07-05.mp4

Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprite approved

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Mar 24, 2024
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things.

code/modules/paperwork/desk_bell.dm Outdated Show resolved Hide resolved
code/modules/paperwork/desk_bell.dm Outdated Show resolved Hide resolved
code/modules/paperwork/desk_bell.dm Outdated Show resolved Hide resolved
code/modules/paperwork/desk_bell.dm Outdated Show resolved Hide resolved
code/modules/paperwork/desk_bell.dm Outdated Show resolved Hide resolved
code/modules/paperwork/desk_bell.dm Outdated Show resolved Hide resolved
@SabreML SabreML added this pull request to the merge queue Mar 24, 2024
Merged via the queue into cmss13-devs:master with commit b5a595c Mar 24, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sound Blast 5 minutes of bass boosted music to our players Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants