Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revives #5330: Desk Bells #5973

Merged
merged 7 commits into from
Mar 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions code/modules/paperwork/desk_bell.dm
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
// A receptionist's bell

/obj/item/desk_bell
name = "desk bell"
desc = "The cornerstone of any customer service job. You feel an unending urge to ring it."
icon = 'icons/obj/objects.dmi'
icon_state = "desk_bell"
w_class = SIZE_SMALL
embeddable = FALSE
/// The amount of times this bell has been rang, used to check the chance it breaks.
var/times_rang = 0
/// Is this bell broken?
var/broken_ringer = FALSE
/// Holds the time that the bell can next be rang.
COOLDOWN_DECLARE(ring_cooldown)
/// The length of the cooldown. Setting it to 0 will skip all cooldowns alltogether.
var/ring_cooldown_length = 5 SECONDS // This is here to protect against tinnitus.
/// The sound the bell makes.
var/ring_sound = 'sound/misc/desk_bell.ogg'

/obj/item/desk_bell/attack_hand(mob/living/user)
if(!ishuman(user))
return FALSE
if(!anchored)
return ..()
if(!COOLDOWN_FINISHED(src, ring_cooldown))
return FALSE
if(!ring_bell(user))
to_chat(user, SPAN_NOTICE("[src] is silent. Some idiot broke it."))
return FALSE
return TRUE

/obj/item/desk_bell/MouseDrop(atom/over_object)
var/mob/mob = usr
if(!Adjacent(mob) || anchored)
return
if(!ishuman(mob))
return

if(over_object == mob)
mob.put_in_hands(src)

/obj/item/desk_bell/attackby(obj/item/item, mob/user)
//Repair the desk bell if its broken and we're using a screwdriver.
if(HAS_TRAIT(item, TRAIT_TOOL_SCREWDRIVER))
if(broken_ringer)
visible_message(SPAN_NOTICE("[user] begins repairing [src]..."), SPAN_NOTICE("You begin repairing [src]..."))
Waseemq1235 marked this conversation as resolved.
Show resolved Hide resolved
if(do_after(user, 5 SECONDS, INTERRUPT_ALL, BUSY_ICON_GENERIC))
user.visible_message(SPAN_NOTICE("[user] repairs [src]."), SPAN_NOTICE("You repair [src]."))
playsound(src, 'sound/items/Screwdriver.ogg', 50)
broken_ringer = FALSE
times_rang = 0
return TRUE
return FALSE

//Return at this point if we're not on a turf so we don't anchor or unanchor inside our bag/hands or inventory.
if(!isturf(loc))
return

//Wrenching down and unwrenching.
if(HAS_TRAIT(item, TRAIT_TOOL_WRENCH))
if(user.a_intent == INTENT_HARM)
visible_message(SPAN_NOTICE("[user] begins taking apart [src]..."), SPAN_NOTICE("You begin taking apart [src]..."))
playsound(src, 'sound/items/deconstruct.ogg', 35)
if(do_after(user, 5 SECONDS, INTERRUPT_ALL, BUSY_ICON_GENERIC))
visible_message(SPAN_NOTICE("[user] takes apart [src]."), SPAN_NOTICE("You take apart [src]."))
new /obj/item/stack/sheet/metal(get_turf(src))
qdel(src)
return TRUE
else
user.visible_message("[user] begins [anchored ? "un" : ""]securing [src]...", "You begin [anchored ? "un" : ""]securing [src]...")
Waseemq1235 marked this conversation as resolved.
Show resolved Hide resolved
playsound(src, 'sound/items/Ratchet.ogg', 35, vary = TRUE)
Waseemq1235 marked this conversation as resolved.
Show resolved Hide resolved
if(!do_after(user, 2 SECONDS, INTERRUPT_ALL, BUSY_ICON_GENERIC))
return FALSE
user.visible_message("[user] [anchored ? "un" : ""]secures [src].", "You [anchored ? "un" : ""]secure [src].")
Waseemq1235 marked this conversation as resolved.
Show resolved Hide resolved
anchored = !anchored
return TRUE


/// Check if the clapper breaks, and if it does, break it chance to break is 1% for every 100 rings of the bell.
Waseemq1235 marked this conversation as resolved.
Show resolved Hide resolved
/obj/item/desk_bell/proc/check_clapper(mob/living/user)
if(prob(times_rang / 100))
to_chat(user, SPAN_NOTICE("You hear [src]'s clapper fall off of its hinge. Nice job hamfist, you broke it."))
broken_ringer = TRUE

/// Ring the bell.
/obj/item/desk_bell/proc/ring_bell(mob/living/user)
if(broken_ringer)
return FALSE
check_clapper(user)
// The lack of varying is intentional. The only variance occurs on the strike the bell breaks.
COOLDOWN_START(src, ring_cooldown, ring_cooldown_length)
playsound(src, ring_sound, 80)
Waseemq1235 marked this conversation as resolved.
Show resolved Hide resolved
flick("desk_bell_activate", src)
times_rang++
return TRUE
1 change: 1 addition & 0 deletions colonialmarines.dme
Original file line number Diff line number Diff line change
Expand Up @@ -2162,6 +2162,7 @@
#include "code\modules\organs\wound.dm"
#include "code\modules\paperwork\carbonpaper.dm"
#include "code\modules\paperwork\clipboard.dm"
#include "code\modules\paperwork\desk_bell.dm"
#include "code\modules\paperwork\filingcabinet.dm"
#include "code\modules\paperwork\folders.dm"
#include "code\modules\paperwork\notepad.dm"
Expand Down
Binary file modified icons/obj/objects.dmi
Binary file not shown.
32 changes: 30 additions & 2 deletions maps/map_files/USS_Almayer/USS_Almayer.dmm
Waseemq1235 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -3287,6 +3287,11 @@
unacidable = 1;
unslashable = 1
},
/obj/item/desk_bell{
pixel_x = -6;
pixel_y = 10;
anchored = 1
},
/turf/open/floor/almayer/aicore/no_build,
/area/almayer/command/airoom)
"asH" = (
Expand Down Expand Up @@ -16102,6 +16107,11 @@
},
/obj/structure/machinery/door/firedoor/border_only/almayer,
/obj/structure/surface/table/reinforced/almayer_blend/north,
/obj/item/desk_bell{
pixel_x = -6;
pixel_y = -8;
anchored = 1
},
/turf/open/floor/almayer{
icon_state = "test_floor4"
},
Expand Down Expand Up @@ -16392,6 +16402,11 @@
},
/obj/structure/machinery/door/firedoor/border_only/almayer,
/obj/structure/surface/table/reinforced/almayer_blend,
/obj/item/desk_bell{
pixel_x = -6;
pixel_y = 10;
anchored = 1
},
/turf/open/floor/almayer{
icon_state = "test_floor4"
},
Expand Down Expand Up @@ -38947,8 +38962,11 @@
/obj/structure/machinery/door/window/eastleft{
req_access_txt = "8"
},
/obj/item/book/manual/medical_diagnostics_manual,
/obj/item/device/megaphone,
/obj/item/desk_bell{
pixel_x = -6;
pixel_y = 10;
anchored = 1
},
/turf/open/floor/almayer{
icon_state = "sterile_green"
},
Expand Down Expand Up @@ -68571,6 +68589,8 @@
dir = 8;
pixel_x = 17
},
/obj/item/device/megaphone,
/obj/item/book/manual/medical_diagnostics_manual,
/turf/open/floor/almayer{
icon_state = "sterile_green_side"
},
Expand Down Expand Up @@ -77143,6 +77163,11 @@
/obj/structure/machinery/status_display{
pixel_x = -32
},
/obj/item/desk_bell{
anchored = 1;
pixel_x = -8;
pixel_y = 8
},
/turf/open/floor/carpet,
/area/almayer/command/corporateliaison)
"wpu" = (
Expand Down Expand Up @@ -77821,6 +77846,9 @@
dir = 1;
name = "ship-grade camera"
},
/obj/item/desk_bell{
anchored = 1
},
/turf/open/floor/almayer{
dir = 6;
icon_state = "red"
Expand Down
Binary file added sound/misc/desk_bell.ogg
Binary file not shown.
Loading